Skip to content

[DOC] Update tempo-distributed helm chart doc#4370

Merged
knylander-grafana merged 4 commits intografana:mainfrom
knylander-grafana:4326-helm-chart-doc-update
Nov 26, 2024
Merged

[DOC] Update tempo-distributed helm chart doc#4370
knylander-grafana merged 4 commits intografana:mainfrom
knylander-grafana:4326-helm-chart-doc-update

Conversation

@knylander-grafana
Copy link
Copy Markdown
Contributor

@knylander-grafana knylander-grafana commented Nov 23, 2024

What this PR does:

Update Helm chart procedures for accuracy.

New: Large configuration files examples are now collapsed using the collapse shortcode.

image

Which issue(s) this PR fixes:
Fixes these issues in #4326

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Comment thread docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md Outdated
Comment thread docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md Outdated
Copy link
Copy Markdown
Contributor

@ayah-el ayah-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested fixes

Comment thread docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md Outdated
Comment thread docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md Outdated
Comment thread docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md Outdated
Co-authored-by: Ayah Elshaikh <150149197+ayah-el@users.noreply.github.com>
@knylander-grafana
Copy link
Copy Markdown
Contributor Author

A few suggested fixes

Done. would you review again?

Copy link
Copy Markdown
Contributor

@ayah-el ayah-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@knylander-grafana knylander-grafana merged commit bcbb6ae into grafana:main Nov 26, 2024
@knylander-grafana knylander-grafana deleted the 4326-helm-chart-doc-update branch November 26, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Update Helm chart doc

3 participants