Add query-frontend limit for max length of query expression#4397
Merged
electron0zero merged 4 commits intografana:mainfrom Nov 28, 2024
Merged
Add query-frontend limit for max length of query expression#4397electron0zero merged 4 commits intografana:mainfrom
electron0zero merged 4 commits intografana:mainfrom
Conversation
electron0zero
requested review from
ie-pham,
javiermolinar,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
electron0zero
added
area/query
enhancement
javiermolinar
approved these changes
Nov 28, 2024
mapno
approved these changes
Nov 28, 2024
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
I prefer to have 0 disable the limit, but I'm to merge this PR 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In order to protect tempo from massive queries, it's helpful to put a cap on the max query length.
Having a limit on the size of the query saves us from being DOSed by issuing huge queries against tempo.
Added
query_frontend.max_query_expression_size_bytesconfig param for query frontends, defaults to 128 KiB.this can be configured to a value lower of higher by setting it in query_frontend config section like:
users will see it as an error like this:
Loki also limits the size of query expression to 128kb and Mimir has a configurable limit with same name (see grafana/mimir#4604), and both were added for same reasons.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]