Merged
Conversation
ie-pham
requested review from
electron0zero,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
mdisibio
reviewed
Dec 2, 2024
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Very nice improvements 👍 I think it would be worth running the benchmarks with TargetInfoEnabled, and fixing the buffer reuse in that mode. Left a few surface-level comments too.
| } | ||
|
|
||
| return keys, values | ||
| return keys[:count], values[:count] |
Contributor
There was a problem hiding this comment.
Since the slices start with 0 length and are appended to, don't think the reslice or count tracking are needed.
| func SanitizeLabelNameWithCollisions(name string, dimensions []string) string { | ||
| sanitized := strutil.SanitizeLabelName(name) | ||
|
|
||
| if IsIntrinsicDimension(sanitized, dimensions) { |
Contributor
There was a problem hiding this comment.
Can probably replace all of IsIntrinsicDimension with slices.Contains
| resourceValues = resourceValues[:0] | ||
| if p.Cfg.EnableTargetInfo { | ||
| resourceLabels, resourceValues = processor_util.GetTargetInfoAttributesValues(rs.Resource.Attributes, p.Cfg.TargetInfoExcludedDimensions) | ||
| resourceLabels, resourceValues = processor_util.GetTargetInfoAttributesValues(rs.Resource.Attributes, p.Cfg.TargetInfoExcludedDimensions, intrinsicLabels) |
Contributor
There was a problem hiding this comment.
When TargetInfo is enabled, this will still realloc the labels and values on every loop iteration. It should be possible to pass them in to GetTargetInfoAttributesValues to reuse them, which would be a nice improvement in that mode.
Contributor
Author
|
latest benchmarks target info disabled target info enabled |
mdisibio
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Generator improvements based on @mdisibio 's notes for things relating to target_info.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]