Skip to content

Ingester: Rate limit max trace logs and drop too many live traces#4418

Merged
joe-elliott merged 2 commits intografana:mainfrom
joe-elliott:rate-limit-logging
Dec 5, 2024
Merged

Ingester: Rate limit max trace logs and drop too many live traces#4418
joe-elliott merged 2 commits intografana:mainfrom
joe-elliott:rate-limit-logging

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

What this PR does:

  • Drops the max live traces log in the ingesters. This information is redundant with the tempo_discarded_spans_total metrics and costly to log in high volume envs
  • Rate limit "max byte per trace" log lines.
  • Convert instance to use a local logger instead of the global one

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit e617335 into grafana:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants