Distributor shim: add test verifying receiver works (including metrics)#4477
Merged
Distributor shim: add test verifying receiver works (including metrics)#4477
Conversation
yvrhdn
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer and
zalegrala
as code owners
javiermolinar
approved these changes
Dec 19, 2024
| _ metric.Float64ObservableUpDownCounter = Float64ObservableUpDownCounter{} | ||
| _ metric.Int64Observer = Int64Observer{} | ||
| _ metric.Float64Observer = Float64Observer{} | ||
| _ metric.MeterProvider = &MeterProvider{} |
Contributor
There was a problem hiding this comment.
Do you know if we need the pointer? I think we can keep the value receivers, none of the methods modify the struct state
Contributor
Author
There was a problem hiding this comment.
Sure, I've pushed a new commit with just value receivers. Works just as well.
Contributor
Author
Yep, running the docker-compose/local example. If I check /metrics they are there still: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a test that runs the OTel receiver shim and tries to write traces in various formats. It also checks the spans_received/spans_refused metrics are set correctly.
I have also refactored some code:
noop.Meterand remove all empty methodsI'm adding this because updating OTel dependencies is breaking the metrics and we only have slow integration tests to catch this 😞
Which issue(s) this PR fixes:
Fixes #Checklist
Documentation addedNot neededCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]