Skip to content

[Rhythm] Block builder performance improvement#4596

Merged
mdisibio merged 3 commits intografana:mainfrom
mdisibio:bb-reuse-prealloc
Jan 23, 2025
Merged

[Rhythm] Block builder performance improvement#4596
mdisibio merged 3 commits intografana:mainfrom
mdisibio:bb-reuse-prealloc

Conversation

@mdisibio
Copy link
Copy Markdown
Contributor

@mdisibio mdisibio commented Jan 22, 2025

What this PR does:
More low-hanging improvements to block builder:

  • Convert live traces to store byte slices to reduce GC scanning of complex objects. It is now a generic type and the generators still use tempopb structs. Ingesters could now make use of this too.
  • Parallelize proto unmarshal
  • Repoll prealloc slices
  • Query partition end offset and use it to avoid the last empty poll (this is mostly for benchmarking and testing, it is minor for actual performance)

This is about 20% improvement in a larger primarily single tenant cluster.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mdisibio mdisibio merged commit b980aa7 into grafana:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants