Collect inspected bytes by FindByTraceId#4668
Merged
mdisibio merged 1 commit intografana:mainfrom Feb 24, 2025
Merged
Conversation
carles-grafana
force-pushed
the
tracebyidSLO
branch
8 times, most recently
from
2eb8c2c to
e2605fc
Compare
carles-grafana
force-pushed
the
tracebyidSLO
branch
6 times, most recently
from
bc3a1fa to
e4b0756
Compare
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
carles-grafana
commented
Feb 14, 2025
| } | ||
|
|
||
| // newTraceIDV2Handler creates a http.handler for trace by id requests | ||
| func newTraceIDV2Handler(cfg Config, next pipeline.AsyncRoundTripper[combiner.PipelineResponse], o overrides.Interface, combinerFn func(int, string) combiner.GRPCCombiner[*tempopb.TraceByIDResponse], logger log.Logger) http.RoundTripper { |
Contributor
Author
There was a problem hiding this comment.
I split V1 and V2 handlers as they use different combiners and collect metrics in different ways.
joe-elliott
reviewed
Feb 19, 2025
carles-grafana
force-pushed
the
tracebyidSLO
branch
from
e4b0756 to
63b3627
Compare
carles-grafana
force-pushed
the
tracebyidSLO
branch
from
63b3627 to
2de43d0
Compare
joe-elliott
approved these changes
Feb 21, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Collect inspected bytes by FindByTraceId. This includes bytes from ingesters and queriers.
This is only implemented for vParquet4 for simplicity. Older formats will report 0 bytes.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]