Add ability to add artificial delay to push requests#4716
Merged
Conversation
yvrhdn
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer and
zalegrala
as code owners
yvrhdn
force-pushed
the
y/make-tempo-slower
branch
from
9681a78 to
d54b6cd
Compare
|
|
||
| # Pad push requests with an artificial delay, if set push requests will be delayed to ensure | ||
| # an average latency of at least artificial_delay. | ||
| [artificial_delay: <duration> | default = 0ms] |
Member
There was a problem hiding this comment.
update manifest.md as well?
Contributor
Author
There was a problem hiding this comment.
I just tried and it didn't change anything. Seems like it is removing overrides that default to 0.
electron0zero
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a tenant-specific override to pad push requests with an artificial delay. This makes it possible to simulate a slower version of Tempo and see how it impacts the tracing pipeline.
Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]