Skip to content

fix: flaky TestWalBlockFindTraceByID test #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javiermolinar merged 3 commits into from
Mar 4, 2025
Merged

fix: flaky TestWalBlockFindTraceByID test #4787

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea8e91d
fix: flaky TestWalBlockFindTraceByID test
javiermolinar Mar 4, 2025
6746055
changelog
javiermolinar Mar 4, 2025
d474953
convert to uint64
javiermolinar Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ configurable via the throughput_bytes_slo field, and it will populate op="traces
* [BUGFIX] Fix starting consuming log [#4539](https://github.com/grafana/tempo/pull/4539) (@javiermolinar)
* [BUGFIX] Rhythm - fix adjustment of the start and end range for livetraces blocks [#4746](https://github.com/grafana/tempo/pull/4746) (@javiermolinar)
* [BUGFIX] Return the operand as the only value if the tag is already filtered in the query [#4673](https://github.com/grafana/tempo/pull/4673) (@mapno)
* [BUGFIX] Fix flaky test [#4787](https://github.com/grafana/tempo/pull/4787) (@javiermolinar)
* [BUGFIX] Fix memcached settings for docker compose example [#4346](https://github.com/grafana/tempo/pull/4695) (@ruslan-mikhailov)
* [BUGFIX] Fix setting processors in user configurations overrides via API [#4741](https://github.com/grafana/tempo/pull/4741) (@ruslan-mikhailov)
* [BUGFIX] Fix panic on startup [#4744](https://github.com/grafana/tempo/pull/4744) (@ruslan-mikhailov)
Expand Down
2 changes: 1 addition & 1 deletion tempodb/encoding/vparquet4/wal_block_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func TestWalBlockFindTraceByID(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, found)
require.True(t, proto.Equal(trs[i], found.Trace))
require.Greater(t, found.Metrics.InspectedBytes, uint64(40000)) // approximate value
Comment thread
javiermolinar marked this conversation as resolved.
require.Greater(t, found.Metrics.InspectedBytes, 0)
}
})
}
Expand Down