[rhythm] Add endpoint for partition downscaling#4913
Merged
mapno merged 17 commits intografana:mainfrom Jun 11, 2025
Merged
Conversation
Contributor
|
This PR has been automatically marked as stale because it has not had any activity in the past 60 days. |
Introduce `/ingester/prepare-partition-downscale` endpoint to manage ingester partition states. This enables transitions between ACTIVE and INACTIVE states, supporting partition downscaling. Signed-off-by: Mario <mariorvinas@gmail.com>
mapno
force-pushed
the
partition-downscale
branch
from
7e2c936 to
ebb6efd
Compare
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
| import ( | ||
| "net/http" | ||
|
|
||
| kitlog "github.com/go-kit/log" |
Contributor
There was a problem hiding this comment.
Could we use the standard slog instead?
Contributor
Author
There was a problem hiding this comment.
I don't a strong opinion on loggers, but slog is not widely used in the codebase. IMO for consistency the go-kit logger makes more sense.
mdisibio
reviewed
Jun 10, 2025
| } | ||
|
|
||
| // If partition is inactive, make it active. We ignore other states Active and especially Pending. | ||
| if state == ring.PartitionInactive { |
Contributor
There was a problem hiding this comment.
The comment says other states are ignored - but it's not clear what happens in the else condition - are they noops? It might be more clear to do an early return instead?
Contributor
Author
There was a problem hiding this comment.
It's a noop, yes. It still returns with a response with the state of the partition.
ie-pham
pushed a commit
that referenced
this pull request
Apr 8, 2026
* Add endpoint for partition downscaling Introduce `/ingester/prepare-partition-downscale` endpoint to manage ingester partition states. This enables transitions between ACTIVE and INACTIVE states, supporting partition downscaling. Signed-off-by: Mario <mariorvinas@gmail.com> * chlog * Add partition downscale integration tests * fmt * Remove unused code * More stable? * Unnecessary cleanup * Fix harder * Implement missing method * pls * Return partition state * fix * switch * comment --------- Signed-off-by: Mario <mariorvinas@gmail.com>
ie-pham
added a commit
that referenced
this pull request
Apr 9, 2026
* chore(deps): update grpc to v1.79.3, otel to v1.40.0, dskit, and gomemcache Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(deps): update module go.opentelemetry.io/otel/sdk to v1.40.0 [security] (main) (#6518) * fix(deps): update module go.opentelemetry.io/otel/sdk to v1.40.0 [security] | datasource | package | from | to | | ---------- | ---------------------------- | ------- | ------- | | go | go.opentelemetry.io/otel/sdk | v1.38.0 | v1.40.0 | | go | go.opentelemetry.io/otel/sdk | v1.39.0 | v1.40.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> * include missing implementation --------- Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: javiermolinar <javimolina@fastmail.com> * Update dskit and adjust memcached interface signature (#5604) * Update dskit and adjust memcached interface signature * Generate config manifest * [rhythm] Add endpoint for partition downscaling (#4913) * Add endpoint for partition downscaling Introduce `/ingester/prepare-partition-downscale` endpoint to manage ingester partition states. This enables transitions between ACTIVE and INACTIVE states, supporting partition downscaling. Signed-off-by: Mario <mariorvinas@gmail.com> * chlog * Add partition downscale integration tests * fmt * Remove unused code * More stable? * Unnecessary cleanup * Fix harder * Implement missing method * pls * Return partition state * fix * switch * comment --------- Signed-off-by: Mario <mariorvinas@gmail.com> * manifest.md * chore: fix vendor after cherry-pick of 6b3e4a5 Remove e2e vendor files added by the cherry-pick that are inconsistent with the pinned go.mod version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * revert: undo cherry-pick of 6b3e4a5 (partition downscaling feature) Cherry-pick brought in too much unrelated feature code for a release branch: new integration tests, production code, and an e2e dependency upgrade. Will apply the minimal fix (GetSubringForOperationStates on mockRing) manually instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add GetSubringForOperationStates to mockRing to satisfy ring.ReadRing interface Required by dskit upgrade; method added to ring.ReadRing interface. Minimal manual fix — no suitable targeted cherry-pick available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * manifest.md --------- Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Signed-off-by: Mario <mariorvinas@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: javiermolinar <javimolina@fastmail.com> Co-authored-by: Zach Leslie <zach.leslie@grafana.com> Co-authored-by: Mario <mariorvinas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduce
/ingester/prepare-partition-downscaleendpoint to manage ingester partition states. This enables transitions between ACTIVE and INACTIVE states, supporting partition downscaling.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]