[BugFix] Add object name to cache key#4982
Merged
joe-elliott merged 3 commits intografana:mainfrom Apr 11, 2025
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
stoewer
approved these changes
Apr 11, 2025
electron0zero
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Very old caching code assumed that we did not need to use the object name in the cache key. I believe this is technically still true and can't convince myself this is currently causing issues. However, from the perspective of the caching layer there's no way to know this and it absolutely should use the object name in the cache key.
TestCacheForwhich wasn't really testing anything.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]