feature: expose a metric for blockbuilder owned partitions#5042
Merged
javiermolinar merged 6 commits intografana:mainfrom May 26, 2025
Merged
feature: expose a metric for blockbuilder owned partitions#5042javiermolinar merged 6 commits intografana:mainfrom
javiermolinar merged 6 commits intografana:mainfrom
Conversation
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
zalegrala
reviewed
Apr 23, 2025
| partitions := b.getAssignedPartitions() | ||
|
|
||
| for _, p := range partitions { | ||
| metricOwnedPartitions.WithLabelValues(strconv.Itoa(int(p))).Set(1) |
Contributor
There was a problem hiding this comment.
If a partition becomes un-owned, do we have a place to set this back to 0?
Contributor
Author
There was a problem hiding this comment.
I may be wrong, but I think't we can leverage on Prometheus staleness. If the metric has not been updated in the past 5 minutes then it won't show up
mapno
reviewed
Apr 25, 2025
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
LGTM. We could measure it inside b.getAssignedPartitions() and add partition state too.
mapno
reviewed
Apr 25, 2025
mapno
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It adds a new metric to track the partitions owned by a blockbuilder. This will allow us to identify problems with unassigned partitions.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]