Skip to content

feat(export): Add OTLP export support replacing Jaeger agent#5058

Merged
joe-elliott merged 11 commits intografana:mainfrom
iamrajiv:4928
Jul 7, 2025
Merged

feat(export): Add OTLP export support replacing Jaeger agent#5058
joe-elliott merged 11 commits intografana:mainfrom
iamrajiv:4928

Conversation

@iamrajiv
Copy link
Copy Markdown
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #4928

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Copy Markdown
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience, we need to rebase with main but it's looking good

Comment thread integration/util/util.go Outdated
@iamrajiv iamrajiv requested a review from javiermolinar June 19, 2025 05:50
Copy link
Copy Markdown
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, there are some errors from the rebase we need to fix.

@javiermolinar
Copy link
Copy Markdown
Contributor

javiermolinar commented Jul 3, 2025

Breaking changes

Vulture client now sends traces to the OTLP grpc endpoint instead of the Jaeger one. The new default port is 4317

Other changes
There was a bug in the getGRPCEndpoint function in Vulture that trimmed the protocol from the URL

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm good on the change, but i think the "thrift" name is not correct.

Comment thread cmd/tempo-vulture/main.go Outdated
Comment thread integration/util/util.go Outdated
@javiermolinar
Copy link
Copy Markdown
Contributor

@iamrajiv could you sign the license so we can merge it? Thank you!

@iamrajiv
Copy link
Copy Markdown
Contributor Author

iamrajiv commented Jul 4, 2025

done @javiermolinar

@iamrajiv iamrajiv requested a review from javiermolinar July 4, 2025 10:21
@joe-elliott
Copy link
Copy Markdown
Collaborator

thx @iamrajiv for getting this started 🙏

@iamrajiv
Copy link
Copy Markdown
Contributor Author

iamrajiv commented Jul 4, 2025

thank you @javiermolinar and @joe-elliott

@iamrajiv iamrajiv requested a review from joe-elliott July 7, 2025 12:09
@joe-elliott joe-elliott merged commit 21ea562 into grafana:main Jul 7, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace jaeger agent by otlp exporter

3 participants