Drop Vulture Loki dependency#509
Conversation
joe-elliott
left a comment
There was a problem hiding this comment.
Great progress!
I tried to comment on what I was looking for w/r to the random # seeding. If that's unclear please reach out.
6d43578 to
49d3335
Compare
joe-elliott
left a comment
There was a problem hiding this comment.
one nit, then i'll merge.
joe-elliott
left a comment
There was a problem hiding this comment.
this is really close. one last comment, but i can be persuaded otherwise.
| } | ||
| startTime := time.Now().Unix() | ||
| ticker := time.NewTicker(tempoBackoffDuration) | ||
| slot := int64(tempoBackoffDuration/time.Second) * 2 |
There was a problem hiding this comment.
i'd like to drop this slot idea and just generate the directly on the timestamps. i think this will make things easier to replicate outside the vulture.
i also think we should split the read/write tickers. maybe we only want to generate a trace every 30 seconds, but execute a query every 5 seconds?
There was a problem hiding this comment.
i'd like to drop this slot idea and just generate the directly on the timestamps. i think this will make things easier to replicate outside the vulture.
I removed the slot thing but from my POV the result was not great... Maybe I misunderstood something...
But, I think your interval approach is great, so I refactored the code to replicate that behavior. Now it's much cleaner and works flawlessly. Hopefully, it makes some sense!
i also think we should split the read/write tickers. maybe we only want to generate a trace every 30 seconds, but execute a query every 5 seconds?
Done :)
4d62e83 to
3896143
Compare
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
10fe89e to
10f4600
Compare
What this PR does:
This PR refactors Tempo Vulture to remove the actual Loki dep.
Now, instead of searching for traces in Loki we:
Which issue(s) this PR fixes:
Fixes #374
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]