Skip to content

Vulture: check recent traces#5157

Merged
ruslan-mikhailov merged 6 commits intografana:mainfrom
ruslan-mikhailov:vulture-recent-blocks
May 28, 2025
Merged

Vulture: check recent traces#5157
ruslan-mikhailov merged 6 commits intografana:mainfrom
ruslan-mikhailov:vulture-recent-blocks

Conversation

@ruslan-mikhailov
Copy link
Copy Markdown
Contributor

@ruslan-mikhailov ruslan-mikhailov commented May 23, 2025 •
edited
Loading

What this PR does:

  1. Refactoring to simplify code and reduce copy-paste
  2. For reads, do two checks: for recent traces that are <5 minutes old, and for older traces. This allows to check read path that hits to generators and ingesters.

Which issue(s) this PR fixes:
Fixes #

How it has been tested:

  1. unit tests
  2. run the new version in k8s for 4h+. Results: no errors reported

Additionally, checked via debug logs that checks run correctly

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ruslan-mikhailov ruslan-mikhailov force-pushed the vulture-recent-blocks branch 2 times, most recently from 925b29d to 54fcc94 Compare May 23, 2025 13:51
@ruslan-mikhailov ruslan-mikhailov marked this pull request as ready for review May 23, 2025 13:52
@ruslan-mikhailov ruslan-mikhailov mentioned this pull request May 26, 2025
Closed
mapno
mapno reviewed May 26, 2025
View reviewed changes
Comment thread cmd/tempo-vulture/main.go Outdated
@ruslan-mikhailov ruslan-mikhailov force-pushed the vulture-recent-blocks branch from 54fcc94 to 6604866 Compare May 27, 2025 12:25
@ruslan-mikhailov
Copy link
Copy Markdown
Contributor Author

ruslan-mikhailov commented May 27, 2025 •
edited
Loading

+ review fix: increase default value for tempo-recent-traces-backoff-duration

@ruslan-mikhailov ruslan-mikhailov requested a review from mapno May 27, 2025 12:26
mapno
mapno approved these changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruslan-mikhailov ruslan-mikhailov merged commit df1abc5 into grafana:main May 28, 2025
19 checks passed
@ruslan-mikhailov ruslan-mikhailov deleted the vulture-recent-blocks branch May 28, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mapno mapno mapno approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

@carles-grafana carles-grafana Awaiting requested review from carles-grafana carles-grafana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruslan-mikhailov @mapno