Assert max live traces limits in local-blocks processor#5170
Merged
mapno merged 2 commits intografana:mainfrom May 28, 2025
Merged
Assert max live traces limits in local-blocks processor#5170mapno merged 2 commits intografana:mainfrom
mapno merged 2 commits intografana:mainfrom
Conversation
mapno
requested review from
carles-grafana,
electron0zero,
javiermolinar,
joe-elliott,
stoewer,
yvrhdn and
zalegrala
as code owners
mapno
force-pushed
the
assert-live-traces-generator
branch
from
49b9231 to
f651476
Compare
ruslan-mikhailov
approved these changes
May 28, 2025
joe-elliott
approved these changes
May 28, 2025
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice, i like the simplification of removing the config option and making both paths behave the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Asserts max live traces limit in in the non-queue implementation of the localblocks processor.
This helps protect the generator from excessive memory and CPU consumption.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]