Fix to remove some attributes from compare()#5196
Conversation
The switch statement already excludes nestedSetParent, strange, yeah can take a look. |
|
Pushed 2 fixes:
|
* Exclude parent span id from selectAll * update test * Fix to ignore nestedSetParent and other intrinisics from compare(). Fix where a nil attribute could be returned from selectall from scopes without any attributes * changelog * lint * woops lint again
* Exclude parent span id from selectAll * update test * Fix to ignore nestedSetParent and other intrinisics from compare(). Fix where a nil attribute could be returned from selectall from scopes without any attributes * changelog * lint * woops lint again


What this PR does:
When we added the intrinsic for parent span ID, it got automatically included in selectAll for the compare() function. But it isn't useful and excluding it will save significant cpu/mem.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]