Skip to content

Adding a Shutdown Handler#526

Merged
annanay25 merged 15 commits intografana:masterfrom
annanay25:flush-handler
Feb 23, 2021
Merged

Adding a Shutdown Handler#526
annanay25 merged 15 commits intografana:masterfrom
annanay25:flush-handler

Conversation

@annanay25
Copy link
Copy Markdown
Contributor

@annanay25 annanay25 commented Feb 15, 2021

What this PR does:

Adds a shutdown handler that helps with moving all ingester data, from memory/WAL/CompleteBlocks to the backend. This will only be used in case of ingester scaledown.

Which issue(s) this PR fixes:
Fixes #355

Checklist

  • Tests updated
  • NA Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread modules/ingester/flush.go Outdated
…k in ShutdownHandler

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread modules/ingester/flush.go Outdated
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread modules/ingester/instance.go Outdated
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/flush.go Outdated
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25 annanay25 marked this pull request as ready for review February 18, 2021 11:10
@annanay25 annanay25 requested a review from mdisibio as a code owner February 18, 2021 11:10
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/flush.go Outdated
Comment thread modules/ingester/instance.go Outdated
Comment thread modules/ingester/instance.go Outdated
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread modules/ingester/flush.go Outdated
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread modules/ingester/flush.go
Comment thread modules/ingester/flush.go
Comment thread modules/ingester/flush.go
Comment thread modules/ingester/instance.go Outdated
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25 annanay25 merged commit 6456fb9 into grafana:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve /flush handler

4 participants