feat(service-graphs): add database_name_attributes config to service graph processor #5398
Merged
joe-elliott merged 7 commits intografana:mainfrom Dec 12, 2025
Merged
feat(service-graphs): add database_name_attributes config to service graph processor #5398joe-elliott merged 7 commits intografana:mainfrom
joe-elliott merged 7 commits intografana:mainfrom
Conversation
KyriosGN0
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
KyriosGN0
force-pushed
the
db
branch
2 times, most recently
from
cd6a816 to
28aa651
Compare
Contributor
|
This PR has been automatically marked as stale because it has not had any activity in the past 60 days. |
Contributor
Author
|
Not stale |
joe-elliott
reviewed
Nov 15, 2025
| # Enables additional labels for services and virtual nodes. | ||
| [enable_virtual_node_label: <bool> | default = false] | ||
|
|
||
| # list of attribute names used to identify the database name from span attributes. if not set the order is peer.service -> server.address -> network.peer.address -> db.name |
Contributor
There was a problem hiding this comment.
Suggested change
| # list of attribute names used to identify the database name from span attributes. if not set the order is peer.service -> server.address -> network.peer.address -> db.name | |
| # List of attribute names used to identify the database name from span attributes. If it isn't set, the order is peer.service -> server.address -> network.peer.address -> db.name. |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
joe-elliott
reviewed
Dec 12, 2025
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
changelog and we're good merge!
thanks, friend.
| cfg.EnableMessagingSystemLatencyHistogram = false | ||
|
|
||
| cfg.DatabaseNameAttributes = []string{ | ||
| string(semconvnew.DBNamespaceKey), |
Collaborator
There was a problem hiding this comment.
i nearly commented that these are out of order with the previous checks, but these are in fact correct. the previous logic is just awfully convoluted. nice catch
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Contributor
Author
|
@joe-elliott added changelog entry, Thanks! |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Contributor
Author
|
Weird, the linter complains about files I didn't touch |
Collaborator
|
Yeah, I've seen this happen before after rebase. Humorously the files that are failing lint have actually been deleted from main. I'm going to drop the lint requirement real quick and merge. |
joe-elliott
approved these changes
Dec 12, 2025
oleg-kozlyuk-grafana
pushed a commit
to oleg-kozlyuk-grafana/tempo
that referenced
this pull request
Dec 13, 2025
…graph processor (grafana#5398) * add config and check if config exist and use it first if it exist Signed-off-by: AvivGuiser <avivguiser@gmail.com> * add test and update docs Signed-off-by: AvivGuiser <avivguiser@gmail.com> * update the manifest.md Signed-off-by: AvivGuiser <avivguiser@gmail.com> * cleanup and fix comments Signed-off-by: AvivGuiser <avivguiser@gmail.com> * pass 3 default attributes to database_name_attributes Signed-off-by: AvivGuiser <avivguiser@gmail.com> * add changelog entry Signed-off-by: AvivGuiser <avivguiser@gmail.com> * update manifest.md Signed-off-by: AvivGuiser <avivguiser@gmail.com> --------- Signed-off-by: AvivGuiser <avivguiser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AvivGuiser avivguiser@gmail.com
What this PR does:
this PR introduces a array of database name attributes that the service graph processor looks for, if it finds one of them it uses them for edge node name, this is similiar to the way the service graph processor behaves in the otel collector.
the list is currently empty but if we want we can set the
db.nameas default (like in the collector) but that would require changes to the other testWhich issue(s) this PR fixes:
Fixes #5243
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]