[backend-scheduler] require minimum time between tenant sorting#5410
Merged
zalegrala merged 9 commits intografana:mainfrom Jul 17, 2025
Merged
[backend-scheduler] require minimum time between tenant sorting#5410zalegrala merged 9 commits intografana:mainfrom
zalegrala merged 9 commits intografana:mainfrom
Conversation
zalegrala
commented
Jul 15, 2025
zalegrala
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
ruslan-mikhailov,
stoewer and
yvrhdn
as code owners
zalegrala
commented
Jul 16, 2025
joe-elliott
approved these changes
Jul 17, 2025
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice simplification. likely easier to predict behavior here?
Contributor
Author
|
More predictable and improved behavior. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we use a minimum cycle time to ensure we move fast when we can, but not too fast when we don't need to.
New blocks arrive at the end of a poll cycle, and we shouldn't expect to find new work on a tenant which has been drained until then.
BREAKING CHANGE
The config setting
provider.compaction.backoffhas been removed in favor of this simplified approach.Additionally the
compaction_tenant_backoff_totalmetric has been renamed tocompaction_empty_tenant_cycle_totalfor clarity.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]