feat: don't enqueue records to kafka when the context has been cancelled#5499
Merged
javiermolinar merged 4 commits intomainfrom Sep 16, 2025
Merged
feat: don't enqueue records to kafka when the context has been cancelled#5499javiermolinar merged 4 commits intomainfrom
javiermolinar merged 4 commits intomainfrom
Conversation
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
mapno
approved these changes
Sep 9, 2025
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
LGTM, but tests are for some reason failing
davidham
added a commit
that referenced
this pull request
Sep 16, 2025
…grafana/tempo into feature/add-option-to-run-once-and-exit * 'feature/add-option-to-run-once-and-exit' of github.com:grafana/tempo: [tools] repalce missing golangci dependency with fork (#5653) feat: don't enqueue records to kafka when the context has been cancelled (#5499) Gracefully handle unsupported block encodings (#5543) vParquet5: dedicated columns for int values (#5639) Add support for scope in cost-attribution usage tracker (#5646) chore: refactor method to wait for a healthy broker (#5618) Update local docker-compose example to scrape /usage_metrics (#5643) Fix race condition in block-builder test (#5645) Upgrade parquet-go (#5644) Cleanup blocks on startup (#5642) Move tracing install to pkg/tracing (#5634)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR tries to skip enqueue records when the context has been cancelled. This is not perfect since the context can be cancelled right after the check.
It also track it as a different error to allow us to discriminate real kafka errors versus context cancellation ones
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]