Skip to content

Add one more test case in the cost attribution tests #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electron0zero merged 1 commit into from
Aug 22, 2025
Merged

Add one more test case in the cost attribution tests #5565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions modules/overrides/userconfigurable/api/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ func Test_UserConfigOverridesAPI_CostAttribution(t *testing.T) {
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster"}, *limits.CostAttribution.Dimensions)

// PATCH - update the config
patch := `{"cost_attribution":{"dimensions":{"deployment.environment":"environment"}}}`
patch := `{"cost_attribution":{"dimensions":{"namespace":""}}}`
w = httptest.NewRecorder()
req = httptest.NewRequest("PATCH", "/", bytes.NewReader([]byte(patch)))
req = req.WithContext(user.InjectOrgID(req.Context(), tenant))
Expand All @@ -572,7 +572,21 @@ func Test_UserConfigOverridesAPI_CostAttribution(t *testing.T) {
// Verify PATCH response body
err = jsoniter.Unmarshal(w.Body.Bytes(), &limits)
require.NoError(t, err)
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster", "deployment.environment": "environment"}, *limits.CostAttribution.Dimensions)
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster", "namespace": ""}, *limits.CostAttribution.Dimensions)

// PATCH - again update the config but with remapping
// it's treated as a new key because we change the config keys
patchUpdate := `{"cost_attribution":{"dimensions":{"k8s.namespace":"namespace"}}}`
w = httptest.NewRecorder()
req = httptest.NewRequest("PATCH", "/", bytes.NewReader([]byte(patchUpdate)))
req = req.WithContext(user.InjectOrgID(req.Context(), tenant))
overridesAPI.PatchHandler(w, req)
assert.Equal(t, 200, w.Code)

// Verify PATCH response body
err = jsoniter.Unmarshal(w.Body.Bytes(), &limits)
require.NoError(t, err)
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster", "namespace": "", "k8s.namespace": "namespace"}, *limits.CostAttribution.Dimensions)

// GET - verify PATCH merged the config correctly
w = httptest.NewRecorder()
Expand All @@ -582,7 +596,7 @@ func Test_UserConfigOverridesAPI_CostAttribution(t *testing.T) {
assert.Equal(t, 200, w.Code)
err = jsoniter.Unmarshal(w.Body.Bytes(), &limits)
require.NoError(t, err)
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster", "deployment.environment": "environment"}, *limits.CostAttribution.Dimensions)
assert.Equal(t, map[string]string{"k8s.namespace.name": "namespace", "k8s.cluster": "cluster", "namespace": "", "k8s.namespace": "namespace"}, *limits.CostAttribution.Dimensions)
etag := w.Header().Get(headerEtag)

// DELETE - remove the config
Expand Down
Loading