feat: implement trace total size logging#5625
Closed
sienna011022 wants to merge 4 commits intografana:mainfrom
Closed
feat: implement trace total size logging#5625sienna011022 wants to merge 4 commits intografana:mainfrom
sienna011022 wants to merge 4 commits intografana:mainfrom
Conversation
sienna011022
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
reviewed
Sep 8, 2025
| } | ||
|
|
||
| func (s *Tracker) GetCurrentSize(traceID []byte) int { | ||
| token := s.token(traceID) |
Collaborator
There was a problem hiding this comment.
you need to take the lock in this func to prevent concurrent map access. wdyt about just returning the trace size from .Allow() instead? it may be worth benchmarking the two approaches if you feel comfortable doing that.
Contributor
Author
There was a problem hiding this comment.
@joe-elliott thanks I made another PR and I did benchmarking.
It will be efficient if Allow() return the size
3 tasks
Collaborator
|
Closing in favor of https://github.com/grafana/tempo/pull/5628/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds total size logging functionality to track and log the cumulative size of traces processed by the ingester.
This enhancement provides better observability into trace data volume and helps with monitoring resource usage.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]