Support querying live-stores via header#5640
Merged
mapno merged 5 commits intografana:mainfrom Sep 18, 2025
Merged
Conversation
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
mattdurham
reviewed
Sep 15, 2025
mattdurham
reviewed
Sep 15, 2025
| HeaderContentType = "Content-Type" | ||
| HeaderAcceptProtobuf = "application/protobuf" | ||
| HeaderAcceptJSON = "application/json" | ||
| HeaderRecentDataTarget = "X-Recent-Data-Target" |
Contributor
There was a problem hiding this comment.
nit: Isn't the X prefix against the preferences these days for headers?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers
Contributor
Author
There was a problem hiding this comment.
Yeah, but we use that convention within Tempo and Grafana. I wasn't sure what to do in this case. It's a temporary header, so I didn't think much about it. Removed.
ruslan-mikhailov
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It adds support to query the live stores for recent data instead of ingesters by passing the header
Recent-Data-Targetwith valuelive-store. This allows to run both modules at the same time and query one or the other per request.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]