Skip to content

chore: remove duplicated metric to count the number of processed records#5654

Merged
javiermolinar merged 3 commits intomainfrom
cleanup-repeated-metric
Sep 17, 2025
Merged

chore: remove duplicated metric to count the number of processed records#5654
javiermolinar merged 3 commits intomainfrom
cleanup-repeated-metric

Conversation

@javiermolinar
Copy link
Copy Markdown
Contributor

@javiermolinar javiermolinar commented Sep 16, 2025

What this PR does:

I noticed we have three different metrics that measure the same:

tempo_distributor_produce_records_total
tempo_distributor_produce_requests_total
tempo_distributor_kafka_appends_total

image

This PR removes the tempo_distributor_kafka_appends_total.
There are already two other metrics that measure the same:

tempo_distributor_produce_requests_total and tempo_distributor_produce_failures_total

tempo_distributor_produce_records_total is added by kprom here:

kprom.FetchAndProduceDetail(kprom.Batches, kprom.Records, kprom.CompressedBytes, kprom.UncompressedBytes))

tempo_distributor_produce_requests_total is named requests to avoid a name conflict with the above one.

Question: Should we keep both?. Kprom includes a lot of metrics, some of them overlaps with another ones defined by us which on the other hand are tunable and easier to find.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@javiermolinar javiermolinar enabled auto-merge (squash) September 16, 2025 15:30
@javiermolinar javiermolinar merged commit f5aafa4 into main Sep 17, 2025
37 of 38 checks passed
@javiermolinar javiermolinar deleted the cleanup-repeated-metric branch September 17, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants