chore: remove duplicated metric to count the number of processed records#5654
Merged
javiermolinar merged 3 commits intomainfrom Sep 17, 2025
Merged
chore: remove duplicated metric to count the number of processed records#5654javiermolinar merged 3 commits intomainfrom
javiermolinar merged 3 commits intomainfrom
Conversation
mapno
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
I noticed we have three different metrics that measure the same:
tempo_distributor_produce_records_totaltempo_distributor_produce_requests_totaltempo_distributor_kafka_appends_totalThis PR removes the
tempo_distributor_kafka_appends_total.There are already two other metrics that measure the same:
tempo_distributor_produce_requests_totalandtempo_distributor_produce_failures_totaltempo_distributor_produce_records_totalis added by kprom here:tempo/pkg/ingest/writer_client.go
Line 34 in b8f58a8
tempo_distributor_produce_requests_totalis namedrequeststo avoid a name conflict with the above one.Question: Should we keep both?. Kprom includes a lot of metrics, some of them overlaps with another ones defined by us which on the other hand are tunable and easier to find.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]