fixed listing blocks for backend/s3#567
Merged
mdisibio merged 1 commit intografana:masterfrom Mar 4, 2021
wandera:s3-list
Merged
fixed listing blocks for backend/s3#567mdisibio merged 1 commit intografana:masterfrom wandera:s3-list
mdisibio merged 1 commit intografana:masterfrom
wandera:s3-list
Conversation
jojand
requested review from
annanay25,
dgzlopes,
joe-elliott and
mdisibio
as code owners
|
|
annanay25
reviewed
Mar 4, 2021
Contributor
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
Neat! This looks good to me. Is there a reason its marked Draft?
Contributor
Author
Thanks for the fast reply! I was just polishing it a bit. |
mdisibio
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes
tempodb/backend/s3/Blocks()to fetch the complete list of blocks in case theListObjects()result is truncated.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]