vParquet5: remove well-known attribute columns#5696
Merged
stoewer merged 25 commits intografana:mainfrom Oct 17, 2025
Merged
Conversation
89d5b67 to
b65229b
Compare
b65229b to
4481531
Compare
Run 'go run pkg/docsgen/generate_manifest.go'
7b9c44d to
d44c059
Compare
mdisibio
reviewed
Oct 9, 2025
Contributor
mdisibio
left a comment
There was a problem hiding this comment.
Looking really good, I think this migration path for vp4 to vp5 without performance penalty or interruption is great. Left a few qs and comments.
More concise lookup in nested maps
mdisibio
reviewed
Oct 10, 2025
mdisibio
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR consists of the following changes:
Which issue(s) this PR fixes:
Contributes to #5665
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]