Skip to content

Rhythm/livestore: Use liveTraces for max trace size#5757

Merged
joe-elliott merged 5 commits intografana:mainfrom
joe-elliott:fix-live-traces
Oct 16, 2025
Merged

Rhythm/livestore: Use liveTraces for max trace size#5757
joe-elliott merged 5 commits intografana:mainfrom
joe-elliott:fix-live-traces

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

What this PR does:
Correctly uses traceSizes instead of liveTraces for tracking trace sizes across multiple flushes of live traces.

Other changes

  • Tests updated to directly confirm expected behavior
  • Swapped max trace idle/max trace size b/c they were in the wrong places
  • Added a rate limited logger for trace too large so we can diagnose tenant issues

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Copy Markdown
Contributor

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goooo!

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit d39b302 into grafana:main Oct 16, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants