fix(s3): Fix compactor to properly consider SSE-KMS information during metadata copy#5774
Merged
javiermolinar merged 1 commit intografana:mainfrom Oct 21, 2025
Merged
Conversation
steffsas
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
|
|
steffsas
force-pushed
the
fix/sse-compactor
branch
from
6e468bc to
31e1e3d
Compare
Contributor
javiermolinar
left a comment
javiermolinar
left a comment
There was a problem hiding this comment.
Looks good to me. It seems the formatting is not correct. Could you fix it?
steffsas
force-pushed
the
fix/sse-compactor
branch
from
31e1e3d to
78eb9a7
Compare
Contributor
Author
done |
javiermolinar
approved these changes
Oct 21, 2025
Contributor
javiermolinar
left a comment
javiermolinar
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
compactor.goimplementation did not properly handle SSE-KMS information when provided. This has now been fixed. It is important to note thatcore.CopyObjectdoes not respect SSE configuration even if specified viaminio.CopySrcOptions{}, so the code was updated to usecore.Client.CopyObjectinstead.Additional tests were added to ensure that
MarkBlockCompactedcorrectly adheres to the SSE configuration. I refactoredfakeServerWithHeaderto assign all HTTP header to the given pointer instead of a single one for better testing.The changes have been verified with MinIO, MinIO KES, and Tempo. If desired, I can add the accompanying docker compose file to
example/docker-compose/for easier testing and demonstration of SSE-KMS.Which issue(s) this PR fixes:
Fixes #5711
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]