[Enhancement] heavy query weights#5782
Merged
ruslan-mikhailov merged 5 commits intografana:mainfrom Oct 28, 2025
Merged
Conversation
| { | ||
| // Aggregate requiring full trace | ||
| query: "{} | count() > 5", | ||
| expected: TraceQLSearchWeight + 2, // +1 for AllConditions is false, +1 for NeedsFullTrace |
Contributor
Author
There was a problem hiding this comment.
To be sure I understand well what part of the code added weight, I modified it to "weight += 10, 100, 1000` and so on (different on each line), run the test and double-checked comments.
ruslan-mikhailov
force-pushed
the
enhancement/heavy-query-weights
branch
from
cc715f5 to
c538054
Compare
ruslan-mikhailov
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
Contributor
javiermolinar
left a comment
javiermolinar
left a comment
There was a problem hiding this comment.
Code looks good but we need to ensure no contention is happening now. We should also check if we need to bump the MaxBatchSize which is currently 7 by default
ruslan-mikhailov
force-pushed
the
enhancement/heavy-query-weights
branch
from
c538054 to
aa1a033
Compare
Contributor
Author
|
+ rebase from main to resolve conflicts in Changelog |
Contributor
Author
|
I ran internal e2e load tests, no degradation noticed |
javiermolinar
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: It adds three more conditions when to add +1 to weight:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]