removing references to aws-sdk-go v1#5856
Merged
javiermolinar merged 4 commits intografana:mainfrom Nov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Why don't do the same change for the s3_test.go? After removing all the references and running a go mod tidy && go mod vendor the github.com/aws/aws-sdk-go v1.55.7 is deleted from the mod file
git diff
diff --git a/go.mod b/go.mod
index 483163a7e..bd12cc6df 100644
--- a/go.mod
+++ b/go.mod
@@ -6,7 +6,6 @@ require (
cloud.google.com/go/storage v1.56.0
github.com/alecthomas/kong v1.12.1
github.com/alicebob/miniredis/v2 v2.35.0
- github.com/aws/aws-sdk-go v1.55.7
github.com/cespare/xxhash/v2 v2.3.0
github.com/cristalhq/hedgedhttp v0.9.1
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
Contributor
|
@anglerfishlyy the title is a bit misleading, could we change it to something like "removing references to aws-sdk-go v1" ? |
…minio.NoSuchKey, clean backup, ran go mod tidy & vendor,add to changelog.md, make test-e2e-api pass
53dc0d5 to
c674f0c
Compare
Closed
1 task
javiermolinar
approved these changes
Nov 10, 2025
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Migrates the S3 backend from AWS SDK for Go v1 to v2, since v1 reached End of Support on July 31, 2025 and contains known security vulnerabilities (CVE-2020-8911, CVE-2020-8912).
Changes include:
Which issue(s) this PR fixes:
Fixes #4706
Verification:
All unit tests for the S3 backend passed successfully.
References
Related: https://github.com/aws/aws-sdk-go-v2
Note
s3.go) has been fully migrated to AWS SDK v2.