Several fixes and improvements to block flushing, wal replay, file deletion, and logging#593
Merged
mdisibio merged 6 commits intografana:masterfrom Mar 22, 2021
Merged
Conversation
…letion, and logging
joe-elliott
reviewed
Mar 16, 2021
Collaborator
joe-elliott
left a comment
There was a problem hiding this comment.
Nice improvements. Thank you for catching that bug where we leave wal files hanging around for empty tenants. That has been bugging me for awhile.
Some comments/thoughts but overall looks good.
annanay25
reviewed
Mar 17, 2021
…ix to metric on wal deletion errors
This was
linked to
issues
Mar 18, 2021
joe-elliott
reviewed
Mar 18, 2021
joe-elliott
approved these changes
Mar 18, 2021
Collaborator
joe-elliott
left a comment
There was a problem hiding this comment.
one minor concern, but you are welcome to merge as is.
…nic, handle error
joe-elliott
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR improves some stability, error handling, and logging for various things:
Main changes:
Minor changes:
ingester_failed_flushes_totalmetric if error occurs deleting WAL blockWhich issue(s) this PR fixes:
Fixes #357 #579 #598
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]