[BugFix] Metrics streaming releases intermediate/incomplete results#5937
Merged
joe-elliott merged 10 commits intografana:mainfrom Nov 13, 2025
Merged
[BugFix] Metrics streaming releases intermediate/incomplete results#5937joe-elliott merged 10 commits intografana:mainfrom
joe-elliott merged 10 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
5ca795d to
1da129c
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
… signed joe Signed-off-by: Joe Elliott <number101010@gmail.com>
stoewer
approved these changes
Nov 13, 2025
electron0zero
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes a situation where intermediate metrics results are released during TraceQL streaming. For most metrics streams this doesn't matter. However, some metrics functions (like topk) when released early will create inconsistent results.
Before:

After:

The approach taken in this PR was to use the same "shard tracking" functionality currently used for the
most_recentquery hint. The query_range combiner logic has been updated to only release metrics when we know that all jobs that could impact a particular time range are complete.Pros:
Cons:
Streaming Before
before.mp4
Streaming After
after.mp4
Other Changes
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]