Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
| protocols: | ||
| grpc: | ||
| endpoint: "tempo:4317" | ||
| # log_received_spans: |
Contributor
There was a problem hiding this comment.
Do we want to leave this commented?
Collaborator
Author
There was a problem hiding this comment.
i could go either way. i found the constant logging of spans to make it difficult to debug other issues. leave it uncommented? just delete it? wdyt?
Collaborator
Author
There was a problem hiding this comment.
going to merge so i can move forward, but let me know what you think. i'd be glad to clean this up next PR
oleg-kozlyuk-grafana
approved these changes
Dec 4, 2025
Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a new target:
all-3.0that bundles all Tempo 3.0 components in a single binary. Note that this setup requires kafka but only b/c this unblocks me for adding Tempo 3.0 e2e tests. Once we do the 3.0 cleanup then this mode will become the default single binary setup.Other changes
IsSingleBinary()helper func to clean up a lot of hard to read boolean logic checking for two modesall-3.0TestIngeste2e test to test the new 3.0 single binaryChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]