Tighten up block builder encoding validation, fix tests to actually run#6037
Merged
mdisibio merged 3 commits intografana:mainfrom Dec 8, 2025
Merged
Tighten up block builder encoding validation, fix tests to actually run#6037mdisibio merged 3 commits intografana:mainfrom
mdisibio merged 3 commits intografana:mainfrom
Conversation
Contributor
Author
|
BB tests are flakey in CI, so going to look for a few more fixes. |
mdisibio
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
oleg-kozlyuk-grafana
pushed a commit
to oleg-kozlyuk-grafana/tempo
that referenced
this pull request
Dec 10, 2025
…un (grafana#6037) * Tighten up block builder encoding validation, fix tests to actually run * changelog * Better shutdown checks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
(1) The block builder validates the encoding on startup, but it's not restrictive enough. Encodings like "vParquet5-preview1" wouldn't be caught on startup, but much later only when it attempted to flush a block. This tightens the check to only allow encodings that can be used to write new blocks, so deprecated and other preview versions will cause a startup error.
(2) Block-builder tests have been accidentally not running because we were missing the call to
m.Run()inTestMain(). Whoops. This updates it so they run again, but also removes the flood of log statements which made running and understanding the tests quite cumbersome. We can substitute the console logger back in as needed when a regression is introduced.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]