feat: Added flag to disable KIP-714 Kafka client metrics#6046
Merged
oleg-kozlyuk-grafana merged 8 commits intografana:mainfrom Dec 11, 2025
Merged
feat: Added flag to disable KIP-714 Kafka client metrics#6046oleg-kozlyuk-grafana merged 8 commits intografana:mainfrom
oleg-kozlyuk-grafana merged 8 commits intografana:mainfrom
Conversation
oleg-kozlyuk-grafana
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
oleg-kozlyuk-grafana
changed the title
mattdurham
reviewed
Dec 9, 2025
oleg-kozlyuk-grafana
requested a review
from knylander-grafana
as a code owner
Contributor
javiermolinar
left a comment
javiermolinar
left a comment
There was a problem hiding this comment.
Do we want to make this opt-out instead of opt-in? These metrics are very helpful for debugging producer/consumer issues (latency, retries, lag, broker connectivity), and disabling them by default makes Kafka significantly harder to operate. While we’ve replaced some of them with our own metrics, we don’t yet cover the full surface area that kgo provides. It might be better to keep them enabled by default and let users explicitly disable them if needed (e.g., for overhead or cardinality reasons).
Contributor
Author
|
Flipped the meaning of the flag so it's opt-out |
javiermolinar
approved these changes
Dec 11, 2025
oleg-kozlyuk-grafana
changed the title
joe-elliott
pushed a commit
to joe-elliott/tempo
that referenced
this pull request
Dec 12, 2025
oleg-kozlyuk-grafana
added a commit
to oleg-kozlyuk-grafana/tempo
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Disabled Kafka API client metrics as currently unused
Which issue(s) this PR fixes:
https://github.com/grafana/tempo-squad/issues/992
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]