Delete vParquet2 format#6071
Conversation
mdisibio
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
| /*if b.Version == "vParquet2" { | ||
| return fmt.Errorf(DeprecatedError, "vParquet2", "vParquet3") | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
Thoughts on removing vs commenting out?
There was a problem hiding this comment.
I left that there because tracking down that logic check next time we deprecate a version. The issue is that the location of this check can't reference anything in encoding/ or encoding/vParquetX because then it would create a cyclic dependency. Is there a different way we could comment this to be clearer?
| cfg: &Config{ | ||
| WAL: &wal.Config{ | ||
| Version: vparquet2.VersionString, | ||
| Version: "vParquet5-preview1", // Turned into unsupported |
There was a problem hiding this comment.
Is this a different change/related?
There was a problem hiding this comment.
We are deleting the vparquet2 module so we cannot use that string from it anymore. All we need here is a version that is parseable/recognized, but doesn't support writes. Since there isn't another deprecated version, that is the next best thing.
* Delete vParquet2 * changelog * Update tempo cli docs
3 participants
What this PR does:
Following #5688 and #6062 , we can now remove vParquet2 for the next release.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]