compactor: return error if encoding is unsupported#6209
Merged
carles-grafana merged 1 commit intografana:mainfrom Jan 14, 2026
Merged
compactor: return error if encoding is unsupported#6209carles-grafana merged 1 commit intografana:mainfrom
carles-grafana merged 1 commit intografana:mainfrom
Conversation
Otherwise it will panic. This happens when trying to compact preview blocks.
carles-grafana
force-pushed
the
fix-compactor-panic
branch
from
d8aa465 to
f13dab0
Compare
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
| meta := &backend.BlockMeta{ | ||
| BlockID: backend.NewUUID(), | ||
| TenantID: testTenantID, | ||
| Version: "vParquet5-preview6", |
Contributor
There was a problem hiding this comment.
Nit: for test might be more illustrative to have vParquet5-unsupported if that works
Contributor
Author
There was a problem hiding this comment.
it's only versions with "preview" that are considered unsupported. others are considered invalid and already returned an error. see https://github.com/carles-grafana/tempo/blob/fix-compactor-panic/tempodb/encoding/versioned.go#L71
oleg-kozlyuk-grafana
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it will panic.
This happens when trying to compact preview blocks.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]