Add support for Cortex Background Cache#640
Merged
annanay25 merged 11 commits intografana:masterfrom Apr 15, 2021
Merged
Conversation
dgzlopes
requested review from
achatterjee-grafana,
annanay25,
joe-elliott and
mdisibio
as code owners
joe-elliott
reviewed
Apr 12, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Very nice work. I'm impressed with how light of a touch this is. I really expected to have some nasty breaking changes with our Redis/Memcached configs.
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
dgzlopes
force-pushed
the
add-magic-cache
branch
from
36f8bc3 to
81cf202
Compare
annanay25
approved these changes
Apr 15, 2021
Contributor
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
Love how lean and clean our cache package is becoming! Great work Daniel. Left a few minor comments.
Comment on lines
-17
to
-21
| type Client interface { | ||
| Fetch(ctx context.Context, key string) []byte | ||
| Store(ctx context.Context, key string, val []byte) | ||
| Shutdown() | ||
| } |
Contributor
There was a problem hiding this comment.
Amazing work. Have been wanting to reuse the Cortex Cache interfaces for a long time!
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #528
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]