Do deep validation for filter policies in user configurable overrides API#6407
Merged
electron0zero merged 4 commits intografana:mainfrom Feb 9, 2026
Merged
Conversation
move ValidateFilterPolicies into the centralized validation package, consistent with other generator config validators. Also added tests for all validation checks
electron0zero
force-pushed
the
validation_filter_polices
branch
from
6cab845 to
c12eedc
Compare
config.ValidateFilterPolicy only does shallow structural checks. NewSpanFilter additionally validates traceql identifiers, attribute scopes, regex compilation, and intrinsic enum values. Also add test for the support scopes (only resources and span)
electron0zero
changed the title
electron0zero
changed the title
electron0zero
requested review from
carles-grafana,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
mapno
approved these changes
Feb 9, 2026
carles-grafana
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Do deep validation for filter policies in overrides API so we don't allow invalid filter policies via the user-configurable-overrides API.
Moves
ValidateFilterPoliciesinto the centralizedgenerator/validationpackage, consistent with other generator config validators.Switches from
config.ValidateFilterPolicy(shallow structural check) tospanfilter.NewSpanFilterfor full validation. The shallow checkonly verifies that include/exclude are present and match types are valid.
NewSpanFilteradditionally validates:resourceandspanare supported, rejectsevent,link,instrumentation)kind,status,name)Adds test coverage for all validation paths through
NewSpanFilter.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]