Add configurable bloom filters#644
Merged
annanay25 merged 20 commits intografana:mainfrom May 20, 2021
Merged
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
reviewed
Apr 12, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
annanay25
commented
May 14, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Contributor
Author
|
something to note - with the following parameters: the package creates 244 shards. we'll just have that many bloom files in object storage |
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
reviewed
May 17, 2021
joe-elliott
reviewed
May 17, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Some thoughts.
I didn't dig super hard on the tests, but I think testStreamingBlockToBackendBlock will test that the bloom filters are functioning correctly.
the package creates 244 shards. we'll just have that many bloom files in object storage
Yeah, I think this will be ok :). If not we're about to find out.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
mdisibio
requested changes
May 18, 2021
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Nice work, this is much smoother than expected! Left a few comments.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
reviewed
May 19, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Two final thoughts and then I'm good. @mdisibio anything else?
Contributor
|
LGTM after reducing |
mdisibio
approved these changes
May 19, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Provides a way to shard out the bloom filter based on the false positive rate and shard size provided.
Which issue(s) this PR fixes:
Fixes #419
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]