Conversation
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b5aceaea8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (import 'distributor.libsonnet') + | ||
| (import 'ingester.libsonnet') + | ||
| (import 'generator.libsonnet') + |
There was a problem hiding this comment.
Removing the ingester mixin from the top-level composition means these manifests no longer render any ingester StatefulSet/Service, but this change does not switch distributor off the ingester write path. In current code, ingester_write_path_enabled defaults to true (modules/distributor/config.go) and PushBytes still calls sendToIngestersViaBytes whenever that flag is true (modules/distributor/distributor.go), so with zero ingester instances in the ring, ingest requests fail (dskit DoBatchWithOptions returns an error when InstancesCount <= 0). Please keep an ingester deployment or enable/configure the Kafka/live-store write path in the same change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is true, we can default it to false although we will clean up that later on
|
💻 Deploy preview deleted (delete ingesters from jsonnet). |
2 participants
What this PR does:
It cleans up the jsonnet to remove any trace of the ingesters.
It defaults ingester_write_path_enabled to false but we will clean this up in a different PR
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]