Coalesce read configuration for recent data cutoff#6507
Merged
electron0zero merged 4 commits intografana:mainfrom Feb 19, 2026
Merged
Coalesce read configuration for recent data cutoff#6507electron0zero merged 4 commits intografana:mainfrom
electron0zero merged 4 commits intografana:mainfrom
Conversation
`query_frontend.search.query_ingesters_until` is removed in favor of only `query_frontend.search.query_backend_after`
mapno
commented
Feb 19, 2026
| reqCh := make(chan pipeline.Request, s.cfg.IngesterShards+1) | ||
|
|
||
| // build request to search ingesters based on query_ingesters_until config and time range | ||
| // build request to search ingesters based on query_backend_after config and time range |
Contributor
Author
There was a problem hiding this comment.
There are still references to ingesters. I'm leaving them to not conflict with when this code is cleaned up.
Contributor
Author
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
knylander-grafana,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
| ifneq ($(GIT_COMMON_DIR),.git) | ||
| WORKTREE_DOCKER_MOUNT := -v $(GIT_COMMON_DIR):$(GIT_COMMON_DIR) | ||
| endif | ||
| endif |
| max_result_limit: 0 | ||
| max_duration: 168h0m0s | ||
| query_backend_after: 15m0s | ||
| query_ingesters_until: 30m0s |
Contributor
There was a problem hiding this comment.
Is this definitely cleared out of JSonnet? Pods crashloop on unknown param IIRC
Contributor
Author
There was a problem hiding this comment.
I get only docs results for the config now.
| * [CHANGE] Remove all traces of ingesters from the dashboards [#6352](https://github.com/grafana/tempo/pull/6352) (@javiermolinar) | ||
| * [CHANGE] **BREAKING CHANGE** tempo-cli: Support relative time (now, now-1h) for start/end args and standardize on RFC3339 in all commands. [#6458](https://github.com/grafana/tempo/pull/6458) (@electron0zero) | ||
| `query search` command no longer accepts timestamps without timezone (e.g. `2024-01-01T00:00:00`), use RFC3339 (e.g. `2024-01-01T00:00:00Z`) or relative time instead. | ||
| * [CHANGE] **BREAKING CHANGE** Coalesce read configuration for recent data cutoff. `query_frontend.search.query_ingesters_until` is removed in favor of only `query_frontend.search.query_backend_after`. [#](https://github.com/grafana/tempo/pull/) (@mapno) |
Contributor
There was a problem hiding this comment.
Nit: "consolidate" is a better word in this context
oleg-kozlyuk-grafana
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
query_frontend.search.query_ingesters_untilis removed in favor of onlyquery_frontend.search.query_backend_after.query_frontend.search.query_ingesters_untilcould be updated for v3.0 to reference live-stores, but having both parameters is. redundant.This PR also contains a change to the tools image to support git worktrees.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]