Merged
Conversation
Right now, Tempo will panic in the request goroutine if we use a query
like `{ 1 / 0 = 1 }`. Instead, an error should be returned such that the
query simply cannot return any results.
Proximyst
force-pushed
the
mariell/fix-div-by-0
branch
from
3758fec to
b94e9a5
Compare
Proximyst
force-pushed
the
mariell/fix-div-by-0
branch
from
b94e9a5 to
de33f50
Compare
Proximyst
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
Member
Author
|
@codex Please review the PR |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mdisibio
approved these changes
Mar 3, 2026
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Hi, thanks for the fix, interestingly it highlights how we are handling integers and floats differently. Floats aren't panicking, (and digging into it 1.0 / 0.0 results in +Inf). So although we might need to make additional changes later, returning the error here is a straight improvement over panicking.
Can you add a bugfix line to the changelog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, Tempo will panic in the request goroutine if we use a query like
{ 1 / 0 = 1 }. Instead, an error should be returned such that the query simply cannot return any results.Note: the bug and fix were both LLM-driven.
Which issue(s) this PR fixes:
Fixes #6579
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]