[tempo-cli]: add client for submitting redaction jobs#6832
Merged
zalegrala merged 1 commit intografana:mainfrom Apr 7, 2026
Merged
[tempo-cli]: add client for submitting redaction jobs#6832zalegrala merged 1 commit intografana:mainfrom
zalegrala merged 1 commit intografana:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds tempo-cli support for submitting trace redaction batches to the backend-scheduler over gRPC, and adjusts the backend-scheduler client to allow custom transport credentials (for TLS vs plaintext) when dialing.
Changes:
- Add a new
tempo-cli redactcommand that submitsSubmitRedactionrequests with tenant + trace IDs. - Introduce a backend-scheduler client constructor that accepts an explicit transport-credentials dial option.
- Wire the new
redactsubcommand into the CLI root command set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
modules/backendscheduler/client/client.go |
Adds NewWithOptions(...) to allow overriding transport credentials when creating a scheduler gRPC client. |
cmd/tempo-cli/main.go |
Registers the new redact subcommand in tempo-cli. |
cmd/tempo-cli/cmd-redact.go |
Implements redaction submission (trace ID parsing, tenant injection, TLS/insecure dial handling, output formatting). |
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
b21295c to
278126f
Compare
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
278126f to
9dcef02
Compare
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
9dcef02 to
62f63d7
Compare
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
62f63d7 to
627a9c6
Compare
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
627a9c6 to
958a0f0
Compare
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
958a0f0 to
8e75ebf
Compare
zalegrala
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer and
yvrhdn
as code owners
Contributor
|
Will we need docs for --redact? |
Contributor
Author
|
@knylander-grafana I think the CLI itself is self documenting, but I'll send a PR later for docs about redaction. |
stoewer
approved these changes
Apr 7, 2026
zalegrala
force-pushed
the
backendSchedulerRedactionCLI
branch
from
8e75ebf to
3d41760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In #459 we intoduced the redaction job scheduler. Here we include the client to allow job submission over the gRPC interface.
Which issue(s) this PR fixes:
Related #6459
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]