Fix stale event DedicatedAttributes when Trace buffer is reused#6878
Closed
mapno wants to merge 1 commit intografana:mainfrom
Closed
Fix stale event DedicatedAttributes when Trace buffer is reused#6878mapno wants to merge 1 commit intografana:mainfrom
mapno wants to merge 1 commit intografana:mainfrom
Conversation
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a correctness issue in the vParquet5 trace-to-parquet conversion where Event.DedicatedAttributes could retain values from a previously-encoded trace when the Trace buffer is reused during block creation.
Changes:
- Reset
Event.DedicatedAttributesbefore writing event attributes ineventToParquet.
Reset event DedicatedAttributes before writing attributes in eventToParquet. The Trace buffer is reused across traces during block creation (create.go), and unlike resources and spans, events were not resetting their DedicatedAttributes. This caused dedicated event attribute values from a previous trace to leak into subsequent traces occupying the same buffer position.
mapno
force-pushed
the
fix/reset-event-dedicated-attrs
branch
from
545eab5 to
7f8ad29
Compare
Contributor
Author
|
Superseded by #6914 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Reset event
DedicatedAttributesbefore writing attributes ineventToParquet. TheTracebuffer is reused across traces during block creation (create.go), and unlike resources and spans, events were not resetting theirDedicatedAttributes. This caused dedicated event attribute values from a previous trace to leak into subsequent traces occupying the same buffer position.Resources reset at
schema.go:411, spans reset atschema.go:515, but events atschema.go:594were missing the reset.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]