Skip to content

enhancement: reduce default WAL size for livestore#6974

Merged
zhxiaogg merged 6 commits intografana:mainfrom
zhxiaogg:worktree-reduce-wal-size
Apr 16, 2026
Merged

enhancement: reduce default WAL size for livestore#6974
zhxiaogg merged 6 commits intografana:mainfrom
zhxiaogg:worktree-reduce-wal-size

Conversation

@zhxiaogg
Copy link
Copy Markdown
Contributor

@zhxiaogg zhxiaogg commented Apr 15, 2026

What this PR does:

  • reduce the livestore WAL sized by tuning default configs. This could also reduce the cpu/mem usage and potentially improve query performance based on local tests.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copilot AI review requested due to automatic review settings April 15, 2026 18:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the default live-store WAL footprint by tuning down the default retention/cutover parameters in the live-store module configuration.

Changes:

  • Reduce complete_block_timeout default from 1h to 30m.
  • Reduce max_block_duration default from 1m to 30s.
  • Reduce max_block_bytes default from 100MiB to 50MiB.

Comment thread modules/livestore/config.go
Comment thread modules/livestore/config.go Outdated
zhxiaogg added a commit to zhxiaogg/tempo that referenced this pull request Apr 15, 2026
Add CHANGELOG entry for PR grafana#6974. Update configuration docs and manifest
to reflect new defaults: max_block_duration 30s, max_block_bytes 50MB,
complete_block_timeout 30m. Add upgrade note for Tempo 3.0.
zhxiaogg added a commit to zhxiaogg/tempo that referenced this pull request Apr 15, 2026
Add CHANGELOG entry for PR grafana#6974. Update configuration docs and manifest
to reflect new defaults: max_block_duration 30s, max_block_bytes 50MB,
complete_block_timeout 30m. Add upgrade note for Tempo 3.0.
@zhxiaogg zhxiaogg force-pushed the worktree-reduce-wal-size branch from 478cb0d to b60d1be Compare April 15, 2026 18:08
Copilot AI review requested due to automatic review settings April 15, 2026 18:08
@zhxiaogg zhxiaogg changed the title Reduce default WAL size for livestore enhancement: reduce default WAL size for livestore Apr 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread docs/sources/tempo/set-up-for-tracing/setup-tempo/upgrade.md Outdated
Comment thread docs/sources/tempo/configuration/_index.md
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comment thread docs/sources/tempo/set-up-for-tracing/setup-tempo/upgrade.md Outdated
Comment thread docs/sources/tempo/set-up-for-tracing/setup-tempo/upgrade.md Outdated
Comment thread docs/sources/tempo/set-up-for-tracing/setup-tempo/upgrade.md Outdated
Copy link
Copy Markdown
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding docs. The updates look good.

Comment thread docs/sources/tempo/configuration/manifest.md Outdated
Lower default block duration (1m → 30s), max block bytes (100MB → 50MB),
and complete block timeout (1h → 30m) to produce shorter, smaller WAL
blocks and release completed blocks sooner.
Add CHANGELOG entry for PR grafana#6974. Update configuration docs and manifest
to reflect new defaults: max_block_duration 30s, max_block_bytes 50MB,
complete_block_timeout 30m. Add upgrade note for Tempo 3.0.
Correct flush_check_period default from 10s to 5s in config reference.
Update upgrade guide to avoid misleading max_block_duration row that
showed 1m when the current default is now 30s.
Combine the two separate upgrade sections into one table, use MiB
instead of MB, remove PR links, and show full default changes from
the original values.
…after to 15m

Lower complete_block_timeout from 30m to 20m so completed blocks are
released sooner. Align metrics query_backend_after with the search
default (both now 15m). Update all docs accordingly.
Copilot AI review requested due to automatic review settings April 16, 2026 18:45
@zhxiaogg zhxiaogg force-pushed the worktree-reduce-wal-size branch from c63d19c to 2dc8ea4 Compare April 16, 2026 18:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread CHANGELOG.md Outdated
Comment thread docs/sources/tempo/set-up-for-tracing/setup-tempo/upgrade.md
@zhxiaogg zhxiaogg requested a review from mattdurham April 16, 2026 19:54
Copy link
Copy Markdown
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. It might be worth including a bit more about the reason to change the default in the PR summary.

@zhxiaogg zhxiaogg merged commit d2f1825 into grafana:main Apr 16, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants