Skip to content

chore: remove deprecated query_live_store config #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javiermolinar merged 3 commits into from
Apr 23, 2026
+1 −8
Merged

chore: remove deprecated query_live_store config #7048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44f1561
chore: remove deprecated query_live_store config
javiermolinar Apr 23, 2026
027d16b
docs(changelog): add entry for #7048
javiermolinar Apr 23, 2026
596daaf
Potential fix for pull request finding
javiermolinar Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* [CHANGE] Own local block and partition ring helpers [#6808](https://github.com/grafana/tempo/pull/6808) (@javiermolinar)
* [CHANGE] Track invalid trace and span id discards [#6799](https://github.com/grafana/tempo/pull/6799) (@javiermolinar)
* [CHANGE] Deprecate `query_frontend.rf1_after` and query all blocks regardless of replication factor for non-metrics paths. Simplifies 2.x to 3.0 migration. [#6969](https://github.com/grafana/tempo/pull/6969) (@mapno)
* [CHANGE] **BREAKING CHANGE** Remove deprecated `querier.query_live_store` config. This field must be removed from configs on upgrade. [#7048](https://github.com/grafana/tempo/pull/7048) (@javiermolinar)
* [FEATURE] jsonnet: Add KEDA-based horizontal pod autoscaling support for microservices deployment [#6970](https://github.com/grafana/tempo/pull/6970) (@mapno)
* [FEATURE] Add automemlimit support for automatic GOMEMLIMIT configuration. Enable with `memory.automemlimit_enabled: true`. [#6313](https://github.com/grafana/tempo/pull/6313) (@oleg-kozlyuk)
* [FEATURE] Support comparison operators in TraceQL Metrics queries [#6474](https://github.com/grafana/tempo/pull/6474) (@ruslan-mikhailov)
Expand Down
1 change: 0 additions & 1 deletion example/docker-compose/distributed/tempo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ backend_worker:
querier:
frontend_worker:
frontend_address: query-frontend:9095
query_live_store: true

metrics_generator:
registry:
Expand Down
1 change: 0 additions & 1 deletion example/nomad/tempo-distributed/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ compactor:
querier:
frontend_worker:
frontend_address: tempo-query-frontend-grpc.service.consul:9095
query_live_store: true

metrics_generator:
processor:
Expand Down
1 change: 0 additions & 1 deletion integration/operations/config-https.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ backend_scheduler_client:
tls_min_version: VersionTLS12

querier:
query_live_store: true
frontend_worker:
grpc_client_config:
tls_enabled: true
Expand Down
1 change: 0 additions & 1 deletion integration/util/config-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ ingest:
querier:
frontend_worker:
frontend_address: query-frontend:9095
query_live_store: true

metrics_generator:
registry:
Expand Down
4 changes: 0 additions & 4 deletions modules/querier/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ type Config struct {
ShuffleShardingIngestersLookbackPeriod time.Duration `yaml:"shuffle_sharding_ingesters_lookback_period"`
QueryRelevantIngesters bool `yaml:"query_relevant_ingesters"`
SecondaryIngesterRing string `yaml:"secondary_ingester_ring,omitempty"`
// Deprecated: kept only for config compatibility. Querier always uses
// partition-ring query path when available.
QueryLiveStore bool `yaml:"query_live_store,omitempty"`
}
Comment on lines 26 to 27
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep deprecated query_live_store accepted in config

Removing query_live_store from querier.Config turns a previously tolerated key into a hard startup failure for upgraded clusters that still carry it in their config files. Tempo parses config with yaml.UnmarshalStrict (cmd/tempo/main.go:185), so this deletion makes query_live_store an unknown field and causes tempo (and -config.verify) to fail before boot; this is an immediate upgrade break for existing deployments, not just an example cleanup.

Useful? React with 👍 / 👎.


type SearchConfig struct {
Expand Down Expand Up @@ -91,7 +88,6 @@ func (cfg *Config) RegisterFlagsAndApplyDefaults(prefix string, f *flag.FlagSet)
cfg.PartitionRing.MinimizeRequests = true
cfg.PartitionRing.MinimizeRequestsHedgingDelay = 3 * time.Second
cfg.PartitionRing.PreferredZone = ""
cfg.QueryLiveStore = false

f.StringVar(&cfg.Worker.FrontendAddress, prefix+".frontend-address", "", "Address of query frontend service, in host:port format.")
}
Loading