fix(azure): append method on azure backend#736
Merged
joe-elliott merged 5 commits intografana:mainfrom Jun 4, 2021
Merged
Conversation
pedrosaraiva
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
|
|
Collaborator
|
We don't run Tempo on Azure so I'm willing to take this PR if you are testing it there and can confirm it works. Heads up that the Azurite e2e test failed. |
Contributor
Author
|
It's working on our environment |
mdisibio
reviewed
Jun 4, 2021
joe-elliott
approved these changes
Jun 4, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Works for me :)
Thank you for your work on the Tempo Azure Backend!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix an issue with the append method on the Azure backend. The AppendBlock on the azure SDK only works when the block is created as an append blocks.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]