-
Notifications
You must be signed in to change notification settings - Fork 692
Consolidate backend metrics and add hedged request metric #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joe-elliott
merged 3 commits into
grafana:main
from
josephwoodward:ConsolodateHedgeRequestMetrics
Jun 30, 2021
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package instrumentation | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/promauto" | ||
| ) | ||
|
|
||
| var ( | ||
| gcsRequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{ | ||
| Namespace: "tempodb", | ||
| Name: "gcs_request_duration_seconds", | ||
| Help: "Time spent doing GCS requests.", | ||
| Buckets: prometheus.ExponentialBuckets(0.005, 4, 6), | ||
| }, []string{"operation", "status_code"}) | ||
|
|
||
| s3RequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{ | ||
| Namespace: "tempodb", | ||
| Name: "s3_request_duration_seconds", | ||
| Help: "Time spent doing AWS S3 requests.", | ||
| Buckets: prometheus.ExponentialBuckets(0.005, 4, 6), | ||
| }, []string{"operation", "status_code"}) | ||
|
|
||
| azureRequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{ | ||
| Namespace: "tempodb", | ||
| Name: "azure_request_duration_seconds", | ||
| Help: "Time spent doing Azure requests.", | ||
| Buckets: prometheus.ExponentialBuckets(0.005, 4, 6), | ||
| }, []string{"operation", "status_code"}) | ||
|
|
||
| requestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{ | ||
|
josephwoodward marked this conversation as resolved.
|
||
| Namespace: "tempodb", | ||
| Name: "backend_request_duration_seconds", | ||
| Help: "Time spent doing requests.", | ||
| Buckets: prometheus.ExponentialBuckets(0.005, 4, 6), | ||
| }, []string{"operation", "status_code"}) | ||
| ) | ||
|
|
||
| type instrumentedTransport struct { | ||
| legacyObserver prometheus.ObserverVec | ||
| observer prometheus.ObserverVec | ||
| next http.RoundTripper | ||
| } | ||
|
|
||
| func NewGCSTransport(next http.RoundTripper) http.RoundTripper { | ||
| return instrumentedTransport{ | ||
| next: next, | ||
| observer: requestDuration, | ||
| legacyObserver: gcsRequestDuration, | ||
| } | ||
| } | ||
|
|
||
| func NewS3Transport(next http.RoundTripper) http.RoundTripper { | ||
| return instrumentedTransport{ | ||
| next: next, | ||
| observer: requestDuration, | ||
| legacyObserver: s3RequestDuration, | ||
| } | ||
| } | ||
|
|
||
| func NewAzureTransport(next http.RoundTripper) http.RoundTripper { | ||
| return instrumentedTransport{ | ||
| next: next, | ||
| observer: requestDuration, | ||
| legacyObserver: azureRequestDuration, | ||
| } | ||
| } | ||
|
|
||
| func (i instrumentedTransport) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| start := time.Now() | ||
| resp, err := i.next.RoundTrip(req) | ||
| if err == nil { | ||
| i.legacyObserver.WithLabelValues(req.Method, strconv.Itoa(resp.StatusCode)).Observe(time.Since(start).Seconds()) | ||
| i.observer.WithLabelValues(req.Method, strconv.Itoa(resp.StatusCode)).Observe(time.Since(start).Seconds()) | ||
| } | ||
| return resp, err | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package instrumentation | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/cristalhq/hedgedhttp" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/promauto" | ||
| ) | ||
|
|
||
| const ( | ||
| hedgedMetricsPublishDuration = 10 * time.Second | ||
| ) | ||
|
|
||
| var ( | ||
| hedgedRequestsMetrics = promauto.NewCounter( | ||
| prometheus.CounterOpts{ | ||
| Namespace: "tempodb", | ||
| Name: "backend_hedged_roundtrips_total", | ||
| Help: "Total number of hedged backend requests", | ||
| }, | ||
| ) | ||
| ) | ||
|
|
||
| // PublishHedgedMetrics flushes metrics from hedged requests every 10 seconds | ||
| func PublishHedgedMetrics(s *hedgedhttp.Stats) { | ||
| ticker := time.NewTicker(hedgedMetricsPublishDuration) | ||
| go func() { | ||
| for range ticker.C { | ||
| hedgedRequestsMetrics.Add(float64(s.Snapshot().RequestedRoundTrips)) | ||
| } | ||
| }() | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.